Update dependency app_settings to v8.0.3 - #668
Merged
Merged
Conversation
renovate
Bot
requested review from
a team,
hikaru-0602,
kantacky,
masaya-osuga,
suzukimifuyu,
takuyone68 and
tanakarinna
August 2, 2026 17:38
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
kantacky
enabled auto-merge
August 3, 2026 09:49
kantacky
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.0.0→8.0.3Release Notes
spencerccf/app_settings (app_settings)
v8.0.3android/build.gradlenow reads the actualandroid.builtInKotlinGradle property (inherited from the consuming app's root project) instead of guessing from the AGP major version alone.kotlin-androidis only skipped for consumers who have genuinely opted into AGP's built-in Kotlin support; it's still applied (avoiding the 8.0.1 bug) for the defaultandroid.builtInKotlin=false. Verified both branches against a real AGP 9.0.1 project: with the defaultfalse, the plugin builds correctly; withtrue, skippingkotlin-androidavoids the'org.jetbrains.kotlin.android' plugin is no longer required for Kotlin support since AGP 9.0failure that other still-unmigrated plugins in the same build hit.v8.0.2android/build.gradlenow setscompileSdk = 36/minSdk = 16(property-assignment syntax) instead of the deprecatedcompileSdkVersion 36/minSdkVersion 16method-call syntax, since the latter is unavailable under AGP 9's "new DSL" mode. Property assignment has worked since AGP 7.0, so this is backward-compatible with AGP 7.x/8.x too. Adapted from a suggestion at qeepcologne/app_settings@agp9-new-dsl.v8.0.1android/build.gradleno longer conditionally skips applying thekotlin-androidplugin on AGP 9+. That guard broke every consuming app on AGP 9 with the (default)android.builtInKotlin=false, producingerror: cannot find symbol / class AppSettingsPluginin the generated plugin registrant at build time.Root cause: Flutter's own Gradle tooling (
FlutterPluginUtils.detectApplyingKotlinGradlePlugin) decides whether to auto-applykotlin-androidfor a plugin subproject by regex-matching the literalapply plugin: 'kotlin-android'text in that subproject'sbuild.gradle— it does not evaluate Groovy conditionals. So even though our runtime guard (if (!isAgp9OrAbove) { ... }) skipped applying the plugin on AGP 9, Flutter's static text-based detection still saw the line and assumed KGP was already handled, so it didn't apply it either. Net effect: nothing ever compiled this module's Kotlin source on AGP 9. Verified against a real AGP 9.0.1 / Gradle 9.1.0 project. See #270 for the original guard.Configuration
📅 Schedule: (in timezone Asia/Tokyo)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.