ci(icarus-kat): add 6 runtime-divergence specs to the GF-T Verilog gate (99 -> 105) - #358
Merged
Merged
Conversation
Unlocked by t27#1991 (test-block call temps re-materialized after a rebinding). The `st = op(st)` repeated-step pattern no longer reuses a stale CSE snapshot on the Verilog path, so these specs' test blocks now execute correctly under Icarus: congestion_control, flow_control, network_simulator, production_scenarios, quarantine_manager, traffic_animator icarus gate 99 -> 105. Only 2 runtime divergences remain out: link_quality_monitor (signed-i8 vs unsigned-const comparison lowering) and rti_security (a spec-side assertion arithmetic bug, fails under Rust/Zig/C too -- not a codegen issue). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlocked by t27#1991: test-block call temporaries are re-materialized after a rebinding, so the
st = op(st)repeated-step pattern no longer reuses a stale CSE snapshot on the Verilog path.These 6 specs' test blocks now execute correctly under Icarus and join the required GF-T KAT gate:
icarus gate 99 -> 105. Only 2 runtime divergences remain out of the gate:
link_quality_monitor— Verilog does an unsigned comparison where a signedi8operand meets an unsigned const (needs signed-lowering in gen-verilog; next wave)rti_security— a spec-side arithmetic assertion bug (3*100+10*10+200asserted== 700, should be600); fails under Rust/Zig/C too, not a codegen issueLocal run against these specs: all pass; full 99-spec gate re-run: 0 regressions.
🤖 Generated with Claude Code