Formatting, spelling, and minor wording improvements to the Refget Sequences spec#102
Merged
nsheff merged 3 commits intoga4gh:masterfrom May 28, 2025
Merged
Conversation
Spell "implementer" thus throughout; fix "heterogeneous" typo; put a space between sentences; capitalise FASTA; hyphenate "foo-based system"; avoid line break within regex. Adjust to python-markdown's dialect: reformat lists, in particular indent nested lists by 4 spaces; links inside <table> must be raw HTML links.
This is presumably intended to be a whole-string match for "case-insensitive IUPAC letters, possibly followed by a '*' character". Fix \ escaping and remove spurious ".
In "Namespace of the checksums", there are two pairs of similar sequences; "... also ..." could suggest all four are the same.
tcezard
approved these changes
May 27, 2025
Member
|
fine with me @andrewyatz these are mostly minor corrections to the sequences standard, so it's probably you who should confirm this. |
nsheff
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had reason to reread this spec carefully for the first time in quite some time.
This PR makes some very minor rewordings for clarity, fixes some spelling and incorrect words, and fixes up some formatting that had not been adjusted to suit mkdocs's slightly different markdown dialect.