Skip to content

Clarify defaults#108

Merged
nsheff merged 4 commits intomasterfrom
defaults
Nov 12, 2025
Merged

Clarify defaults#108
nsheff merged 4 commits intomasterfrom
defaults

Conversation

@nsheff
Copy link
Copy Markdown
Member

@nsheff nsheff commented Oct 15, 2025

No description provided.

@nsheff nsheff requested review from sveinugu and tcezard October 15, 2025 12:28
Comment thread docs/seqcols/README.md Outdated
- Set to `true` for local qualifiers (e.g., `collated: true`)
- Included in the appropriate array for global qualifiers (e.g., listed in `ga4gh.inherent`)

While the default for `required` and `ga4gh.inherent` arrays is `[]`, implementations SHOULD explicitly specify these arrays in their service-info schemas, as an empty `inherent` array would result in an undefined level 0 digest algorithm.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it even allowed to not have any attribute in the inherent ?
Would this what an implementation with no level 0 identifier would do ?

@nsheff
Copy link
Copy Markdown
Member Author

nsheff commented Oct 15, 2025

Ok. inherent MUST be specified.

an alternative could be to have inherent default to true. for now I changed it to MUST be specified so it's explicit.

Copy link
Copy Markdown
Collaborator

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Comment thread docs/seqcols/README.md Outdated
Co-authored-by: Timothee Cezard <tcezard@ebi.ac.uk>
@nsheff nsheff merged commit d839b66 into master Nov 12, 2025
@nsheff nsheff deleted the defaults branch November 12, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants