Repository navigation
VA-Spec 1.1.0 Community Review Ballot #443
Replies: 5 comments 11 replies
|
Hi, I have one question about Statement.proposition becoming optional in 1.1.0. |
|
One small documentation issue I noticed: |
|
My understanding based on the VA call today is that the changes to EvidenceLine were intended to be reverted, I see this in PR #449, although this has not been merged and the description of changes above has not been modified to incorporate this. With the exception of the hopefully soon-to-be-removed changes to EvidenceLine--the rest of these changes seem generally appropriate. That said, they are significant, breaking changes to a release that affect all implementations of the spec. Only a week was originally given to review these changes. Effectively twelve hours has been given to review the changes after the change to EvidenceLine (still not reflected in the documentation or code, perhaps it would be more accurate to say no time at all has been given). It is hard to believe an appropriate review of these changes could occur in this timeframe. I suggest withdrawing and resubmitting this ballot proposal incorporating #449, and allowing a reasonable period for review (I don't see how this could be less than two weeks). I do consider the remaining changes to be necessary and acceptable, but I would appreciate an understanding of the process for release and review from the GKM leads and whether what happened with this fits within that process. I would also appreciate an understanding of what one should expect with regards to the stability and usability of this model, or any of the models in GKM. There is a tension between having a v1 model and also having every class be labeled as 'trial use' and subject to change with potentially no notice. |
|
From @mbrush https://docs.google.com/document/d/1ZnF6OquX0qauFfNrqttWonB4mlwcHp4dQaOXK2Oyp3k/edit?tab=t.rtp10ycgyrxp Modeling and Docs
Diagrams
OK to address after the release:
I think this is one of the most informative things about these diagrams, that helps users understand what each class is for. Can the agentic tooling that generates the updated docs include such text? The tool is clearly capable of adding text to these boxes - as we see below describing the focus attribute: I would rather have text with examples of content each class collects, than an explanation of how to use an arbitrarily selected attribute (this guidance can go elsewhere) |
|
@larrybabb Combining EvidenceLine and Statement makes sense to me as a simplification. I think the use of nested Statements in either |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is the ballot pre-release of the VA-Spec 1.1 specification, open for community review following the GA4GH Product Development and Approval process.
Important Links
Documentation: https://va-spec.ga4gh.org/en/1.1.0-ballot.2026-09
Release log: https://va-spec.ga4gh.org/en/1.1.0-ballot.2026-09/releases/1.1.html
Schemas: https://github.com/ga4gh/va-spec/tree/1.1.0-ballot.2026-09.1/schema/va-spec/json
Discussion: this page!
Design Decisions and Rationale: https://docs.google.com/document/d/1UIp0Xnwo_zrGCJdBE3oKjLdW23cBHonAJn66G9zUzj4/edit?usp=sharing
Full Changelog: 1.0.1...1.1.0-ballot.2026-09.1
This discussion was created from the release 1.1.0-ballot.2026-09.1.
What's Changed
Version 1.1.0 consolidates the core
EvidenceLineclass intoStatement: a "discrete evidence-based argument" is now a Statement referenced through another Statement'shasEvidenceLines. It also hasProposition/StudyResultsubclasses narrowsubject/predicate/object/focusin place instead of renaming them per subclass. It restructures the domain entities around GKM Core'sMappableConcept/ConceptSet(Therapeuticis renamedTherapy) and renames the abstractClinicalVariantProposition. The release also adds several draft propositions, substantially revises the draft AAC-2017, ACMG-2015, and CCV-2022 community profiles, modernizes the schema-generation pipeline, and refreshes the imported dependencies to the 2026-09 ballot line.Changes are categorized per the GA4GH TASC Technical Specification Development policy, based on the
maturityof each class touched, and compared against the last full release, 1.0.1. See the release log for full detail.Minor Version Increment
Backwards-incompatible changes and additions to trial use classes:
EvidenceLineis removed.StatementgainshasEvidenceItems, and itshasEvidenceLinesnow holdsStatement | iriReference(wasEvidenceLine | iriReference).EvidenceLine's attributes move ontoStatement:targetProposition→proposition, which is now optional;directionOfEvidenceProvided→direction;strengthOfEvidenceProvided→strength;evidenceOutcomeand Statement'sclassificationmerge intooutcome;qualityOfEvidenceProvided→quality.Propositiondeclaressubject/predicate/objectandStudyResultdeclaresfocus, and every subclass narrows them in place:subjectVariant→subject;objectCondition/objectTumorType/objectSequenceFeature/objectTherapeutic→object;focusAllele/focusVariant→focus. The abstractProposition,StudyResult, andSubjectVariantPropositionbases are now open, so implementers can define their own subclasses.Therapeuticis renamedTherapy.ConditionandTherapyare now singleMappableConceptspecializations, and the single-or-set union moves to where they're used (e.g.object:Condition | ConditionSet | iriReference).ConditionSetandTherapyGroupnow specializeConceptSet, withconditions/therapiesrenamedconcepts.MappableConcept/ConceptSet. Both now require atypediscriminator, which propagates toCondition,Therapy,ConditionSet, andTherapyGroup.ConditionSetandTherapyGroupnow accept the optionalconceptSetType.ClinicalVariantProposition→GeneticContextVariantProposition.CohortAlleleFrequencyStudyResultfocusAlleleCount→focusCount,locusAlleleCount→locusCount, andfocusAlleleFrequency→alleleFrequency.iriReferencein place of an inline object on attributes that reference independently-identifiable entities. Examples:Contribution.contributor,Statement.proposition/.strength/.outcome/.quality,StudyResult.sourceDataSet, andVariantPathogenicityProposition's qualifiers.Patch Version Increment
New draft features, changes to draft classes, and supporting changes:
GeneDiseaseValidityProposition,VariantMolecularConsequenceProposition,VariantClinicalSignificanceProposition, andDataItem(all draft).AmpAscoCapStatementand itsDiagnostic/Prognostic/TherapeuticStatementsubclasses.Statement;methodTypecodes are normalized tosnake_case;no_criteria_metoutcomes are added; theif/thentier constraints are fixed; andhasEvidenceLinesaccepts IRIs.ga4gh.gkm.metaschema0.4.8 and its source conventions, and emits a JSON Schema for every abstract class.schema/va-spec/into a flat folder using the processor's profile sub-namespace convention, and makes the docs self-contained.1.1.1, VRS2.1.1, and GKM Core1.3.0(Repin VRS to 2.1.1 and Cat-VRS to 1.1.1 ballots (were 2.2.0 / 1.2.0) #446).All reactions