-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[25.0] Add SpatialData datatype #21000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
283c6b1 to
1cf17a9
Compare
the ome_zarr is somehow detected as zarr.zip |
davelopez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a question about metadata usage below:
|
|
||
| file_ext = "spatialdata.zip" | ||
|
|
||
| MetadataElement( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is all this metadata used by any existing or future tool?
I think we want to keep metadata as minimal as possible since this is information that goes into the database for each dataset. So it is important to keep only the essential metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is needed, then it is needed :)
I just wanted to make sure.
|
This PR was merged without a "kind/" label, please correct. |
|
Thanks @nilchia and @davelopez! One comment: since last week's release, Example Reveal the zarr.json{
"attributes": {
"ome": {
"omero": {
"channels": [
{
"label": 0
}
]
},
"version": "0.5-dev-spatialdata",
"multiscales": [
{
"datasets": [
{
"path": "0",
"coordinateTransformations": [
{
"type": "scale",
"scale": [
1.0,
1.0,
1.0
]
}
]
}
],
"name": "/images/rasterized",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space"
},
{
"name": "x",
"type": "space"
}
],
"coordinateTransformations": [
{
"type": "sequence",
"transformations": [
{
"type": "scale",
"scale": [
1.0,
3.863113519548272,
3.5077751335606355
],
"input": {
"name": "cyx",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space",
"unit": "unit"
},
{
"name": "x",
"type": "space",
"unit": "unit"
}
]
},
"output": {
"name": "global",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space",
"unit": "unit"
},
{
"name": "x",
"type": "space",
"unit": "unit"
}
]
}
},
{
"type": "translation",
"translation": [
0.0,
4548.0,
1154.0
],
"input": {
"name": "cyx",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space",
"unit": "unit"
},
{
"name": "x",
"type": "space",
"unit": "unit"
}
]
},
"output": {
"name": "global",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space",
"unit": "unit"
},
{
"name": "x",
"type": "space",
"unit": "unit"
}
]
}
}
],
"input": {
"name": "cyx",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space",
"unit": "unit"
},
{
"name": "x",
"type": "space",
"unit": "unit"
}
]
},
"output": {
"name": "global",
"axes": [
{
"name": "c",
"type": "channel"
},
{
"name": "y",
"type": "space",
"unit": "unit"
},
{
"name": "x",
"type": "space",
"unit": "unit"
}
]
}
}
]
}
]
},
"spatialdata_attrs": {
"version": "0.3"
}
},
"zarr_format": 3,
"consolidated_metadata": null,
"node_type": "group"
} |
|
Thanks @LucaMarconato for the info, I made a new PR here |






I'm trying to add spatialdata as a new data type in Galaxy.
spatialdata is a data framework that comprises a FAIR storage format and a collection of python libraries for performant access, alignment, and processing of uni- and multi-modal spatial omics datasets.
The metadata should be sth like this:
How to test the changes?
(Select all options that apply)
License