-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[25.0] Add SpatialData datatype #21000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b818dad
start adding spatialdata
nilchia ac85e40
add test
nilchia 340a0d6
check the elements in root dir and first sub dir
nilchia 3915422
update class
nilchia 9c5f921
add metadataelement
nilchia df5171a
add set peek
nilchia 8c77942
fix identation
nilchia d6cba64
add set_meta
nilchia 804aecd
add the datatype to conf
nilchia 36d68db
correct name
nilchia ce2f76f
add the spatialdata sniffer before generic zarr
nilchia fd3ef7a
check the spatialdata attr to get more specific sniff
nilchia 19679bb
metadata display like AnnData
nilchia dfce6f1
show table dimension
nilchia 1cf17a9
add omezarr file for negative test
nilchia 2c38292
remove the redundant class caused by merging conflicts
nilchia be72931
fix python lint
nilchia 3323d57
fix lint
nilchia bd010a1
fix lint with black
nilchia 49bf354
change data type of zarr object to zarr.zip
nilchia 67d724c
minimize metadata
nilchia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is all this metadata used by any existing or future tool?
I think we want to keep metadata as minimal as possible since this is information that goes into the database for each dataset. So it is important to keep only the essential metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata is really needed for the users to inspect the info in the data.

I tried to minimize it here:
is it good enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is needed, then it is needed :)
I just wanted to make sure.