Skip to content

[25.1] update the binary.py for spatialdata so it also works if the file has…#22802

Merged
davelopez merged 2 commits into
galaxyproject:release_25.1from
nilchia:update_spdata_class
Jun 2, 2026
Merged

[25.1] update the binary.py for spatialdata so it also works if the file has…#22802
davelopez merged 2 commits into
galaxyproject:release_25.1from
nilchia:update_spdata_class

Conversation

@nilchia
Copy link
Copy Markdown
Contributor

@nilchia nilchia commented Jun 1, 2026

in galaxy the sniff only works if the directory in the spatialdata.zip ends with ".zarr".

This update solves this problem.

How to test the changes?

(Select all options that apply)

  • [] I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-project-automation github-project-automation Bot moved this to Needs Review in Galaxy Dev - weeklies Jun 1, 2026
@nilchia nilchia requested a review from davelopez June 1, 2026 15:17
@github-actions github-actions Bot changed the title update the binary.py for spatialdata so it also works if the file has… [25.1] update the binary.py for spatialdata so it also works if the file has… Jun 1, 2026
@github-actions github-actions Bot added this to the 26.2 milestone Jun 1, 2026
@nilchia
Copy link
Copy Markdown
Contributor Author

nilchia commented Jun 1, 2026

Should I make it against 26.0?

Comment thread lib/galaxy/datatypes/binary.py Outdated
Copy link
Copy Markdown
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nilchia!

@nilchia
Copy link
Copy Markdown
Contributor Author

nilchia commented Jun 2, 2026

Thanks. Should I make a PR also for 26.0?
Or will it get automatically updated?

@davelopez davelopez merged commit c0df64d into galaxyproject:release_25.1 Jun 2, 2026
49 of 52 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Jun 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

This PR was merged without a "kind/" label, please correct.

@davelopez
Copy link
Copy Markdown
Contributor

It will get merged forward at some point to all following versions, no need for a new PR 👍 but it may take some time.

@nilchia nilchia deleted the update_spdata_class branch June 2, 2026 10:01
@nsoranzo nsoranzo modified the milestones: 26.2, 26.1 Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants