Rewrite IsAspherical - #158
Merged
Merged
Conversation
... to use higher level polymaking interfaces; this makes it more robust (e.g. it catches and reports errors, unlike `Exec`), and also compatible with future improvements to polymaking.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 43.84% 43.82% -0.02%
==========================================
Files 364 364
Lines 66466 66443 -23
==========================================
- Hits 29141 29118 -23
Misses 37325 37325
🚀 New features to boost your workflow:
|
Member
Author
|
@grahamknockillaree I hope this is OK for you. Having this in HAP would make it much easier to make some major improvements to the polymaking package :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to use higher level polymaking interfaces; this makes it more
robust (e.g. it catches and reports errors, unlike
Exec), andalso compatible with future improvements to polymaking.