Skip to content

Fix deprecated function use in dependabot bump of google.golang.org/api from 0.256.0 to 0.258.0#737

Merged
Bobi-Wan merged 2 commits intogardener:mainfrom
Bobi-Wan:fix-dependabot-pr
Jan 6, 2026
Merged

Fix deprecated function use in dependabot bump of google.golang.org/api from 0.256.0 to 0.258.0#737
Bobi-Wan merged 2 commits intogardener:mainfrom
Bobi-Wan:fix-dependabot-pr

Conversation

@Bobi-Wan
Copy link
Copy Markdown
Contributor

@Bobi-Wan Bobi-Wan commented Jan 6, 2026

What this PR does / why we need it:
Dependabot bumped google.golang.org/api from 0.256.0 to 0.258.0 here
The new version deprecates the function WithCredentialsFile, which we use, in favour if WithAuthCredentialsFile.
Since the linter doesn't allow that to pass, this fixes the PR.
The extra option that now needs to be specified is currently documented as a Service account on our end, so I am using the option.ServiceAccount type there.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove deprecated function use.

dependabot Bot and others added 2 commits January 6, 2026 02:43
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.256.0 to 0.258.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.256.0...v0.258.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-version: 0.258.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
… which includes the deprecation of the WithCredentialsFile function
@Bobi-Wan Bobi-Wan requested a review from a team as a code owner January 6, 2026 00:48
@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2026
@dnaeon
Copy link
Copy Markdown
Member

dnaeon commented Jan 6, 2026

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 6, 2026
@Bobi-Wan Bobi-Wan merged commit a7f65b6 into gardener:main Jan 6, 2026
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 6, 2026
@Bobi-Wan Bobi-Wan deleted the fix-dependabot-pr branch January 7, 2026 09:06
@Bobi-Wan
Copy link
Copy Markdown
Contributor Author

Bobi-Wan commented Jan 8, 2026

This fix is not working correctly. Looking into this.
The PR that deprecated the WithCredentialsFile function is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed/lgtm Has approval for merging size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants