Closed
Conversation
…ServiceAccount to ExternalAccount (we use workload identity, which uses an external_account type for it's credential files
gardener-robot
added
needs/review
Contributor
Author
|
The credential file type was correct, there is a bug in the GCP storage client we use that we actually hit: |
gardener-robot
added
the
status/closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A previous PR incorrectly set the credential file we use for GCP as type ServiceAccount. This breaks out pipelines, as we actually use credentials of type external account (workflow identity federation). The fix is added here.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
If an external Inventory adopter was to use a normal GCP service account credential file (type: service_account), this fix would break HIS pipeline, but the impact here is minor.
Just in case, an issue has been created here:
#739
Release note: