You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an initial implementation of resolving local URIs of the form e.g. <something>://dir/file.stl where <something> is part of IGN_GAZEBO_RESOURCE_PATH.
After parsing a URDF/SDF model, calling Model.resolve_uris() will replace all the URIs with the real path to the local file.
While we may not want to support the legacy GAZEBO_MODEL_PATH, perhaps we can already start using also the new GZ_SIM_RESOURCE_PATH?
This is why this PR just partially resolves #8 😆 Yep for the moment I can extend the search also to all three variables (I don't see why we should not support Gazebo Classic since it's effortless).
However, there's more than that, like SDF_PATH (see here), fuel URIs, etc. Thanks for opening an issue upstream, having a more extensive documentation of all the supported URIs might be useful. Most of the information is there, but I remember in the past it happened that I had to dig into the code to check specific details of environment details.
Then, there are Fuel links. Furthermore, I've seen in the past both model:// and file://. Again, I'm not 100% confident I have right now all the information for a complete implementation of URI support. I commented in #8 as a reminder and for the time being I only add what you suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of resolving local URIs of the form e.g.
<something>://dir/file.stlwhere<something>is part ofIGN_GAZEBO_RESOURCE_PATH.After parsing a URDF/SDF model, calling
Model.resolve_uris()will replace all the URIs with the real path to the local file.Partially resolves #8.