Improve model handling speed#31
Conversation
|
@flferretti there are many conflicts after #34 and #35. Do you want to port the changes over the future main? Otherwise I can take care of it since I was the one that introduced all the conflicts. |
I can handle that, thank you! |
b3d595e to
8d6da11
Compare
8d6da11 to
c4e35b1
Compare
c4e35b1 to
c6ccc60
Compare
|
Ready for review @diegoferigo, I also fixed a minor typo here https://github.com/ami-iit/rod/blob/11d276868a6720439d8ce9db9d64f209500a1b79/src/rod/utils/frame_convention.py#L297 |
diegoferigo
left a comment
There was a problem hiding this comment.
Looks almost good, I have only a doubt on a possible change of behavior.
833f1f9 to
bdaf332
Compare
Co-authored-by: Diego Ferigo <diego.ferigo@iit.it>
bdaf332 to
f19d41c
Compare
diegoferigo
left a comment
There was a problem hiding this comment.
Beyond the suggestion below that somehow got lost, this PR looks good thanks! We can finalize the type hints migration with list, dict, set, |None, etc in the future.
This pull request includes several code improvements and bug fixes. Here is a summary of the changes:
utf-8encoding when reading from files (Avoids file read error in Windows)Benchmarks:
C.C. @diegoferigo