Skip to content

Fix possible overflow in incoming and finished counters. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2017
Merged

Fix possible overflow in incoming and finished counters. #8

merged 2 commits into from
Dec 24, 2017

Conversation

@danielfireman
Copy link
Contributor

@danielfireman danielfireman commented Dec 23, 2017

Also adding unit tests to interceptor and renaming gccontrol.New to gccontrol.NewInterceptor

Fix #1

@danielfireman
Fix possible overflow in incoming and finished counters. Add unit tes…
33b8121 
…ts and rename gccontrol.New to gccontrol.NewInterceptor
@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage increased (+20.4%) to 74.038% when pulling 33b8121 on interceptor into 8deb9ca on master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage increased (+20.4%) to 74.038% when pulling 33b8121 on interceptor into 8deb9ca on master.

@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage increased (+20.4%) to 74.038% when pulling 545cec8 on interceptor into 8deb9ca on master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage increased (+20.4%) to 74.038% when pulling 545cec8 on interceptor into 8deb9ca on master.

dfquaresma
dfquaresma approved these changes Dec 24, 2017
View reviewed changes
Copy link
Member

@dfquaresma dfquaresma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds awesome to me, thanks!
I believe that we have solved the dangerous counters problem. Congratulations!
That PR, with #5 and #6 , fix #1 completely.

@danielfireman danielfireman merged commit f68f18c into master Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dfquaresma dfquaresma dfquaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danielfireman @coveralls @dfquaresma