[Backport 4.2.x] Harden login redirect URL validation#9309
Merged
Conversation
Centralise the validation of the post-login redirectUrl into a shared RedirectUtil helper and use it from the OIDC and Keycloak authentication filters. Only server-local relative paths are honoured; anything else falls back to the application context home. Add unit tests covering the accepted and rejected redirect targets.
The single-argument isSafeRedirect only accepts server-local relative paths, while the four-argument overload also honours same-site absolute URLs. Naming both isSafeRedirect made the distinction unclear at the call sites. Rename the single-argument method to isRelativeRedirect to make its narrower contract explicit, and update the internal callers and tests accordingly. The four-argument overload keeps the isSafeRedirect name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #9307
Authored by: @juanluisrp