[Backport 2026.02.xx] Fix #12620 cyclomedia orb issue#12638
Merged
Conversation
* Fix #12620 Cyclomedia images not shown Cyclomedia retired the v23.7 StreetSmart API endpoint hardcoded as default; their server now falls back to serving their own web app shell (HTML) instead of a 404, which Chrome blocks as an opaque response (ERR_BLOCKED_BY_ORB) when loaded as a script. Bump default to the current v26.1, confirmed live and API-compatible. Restrict providerSettings.StreetSmartApiURL to cyclomedia.com hosts, consistent with the other cyclomedia endpoints already used by this provider, falling back to the default otherwise. * Show an error when the StreetSmart API fails to load Previously, if the iframe's script tag failed to load or execute (network issue, wrong/dead API version, blocked request), the plugin was left stuck on the "Loading Street Smart API..." spinner forever with no feedback. Detect this on iframe load and surface a proper error message instead. Also fixes a regression from the StreetSmartApiURL host validation: an explicit empty string (used by tests to inject a mocked API via `scripts` instead of loading a real script) was being treated as invalid and replaced with the default URL. (cherry picked from commit c27c111)
5 tasks
1 task
tdipisa
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #12631 to
2026.02.xx.Fixes #12620