Skip to content

feat: show the redirect destination on the Connect App screen - #452

Merged
im-adithya merged 1 commit into
masterfrom
fix/connect-redirect-visibility
Aug 13, 2026
Merged

feat: show the redirect destination on the Connect App screen#452
im-adithya merged 1 commit into
masterfrom
fix/connect-redirect-visibility

Conversation

@im-adithya

@im-adithya im-adithya commented Aug 13, 2026

Copy link
Copy Markdown
Member

Makes redirect link more evident for the user

Summary by CodeRabbit

  • UI Improvements
    • Improved spacing around the insecure relay warning in connection details.
    • Moved the return destination notice to the main wallet connection confirmation area, making it easier to see before continuing.
    • Simplified the connection details view by keeping destination information alongside the primary confirmation action.

@im-adithya
im-adithya merged commit efe9a1c into master Aug 13, 2026
2 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d4ef879b-ca29-4056-90a9-9357c037614a

📥 Commits

Reviewing files that changed from the base of the PR and between a24016a and ea073f8.

📒 Files selected for processing (2)
  • components/ConnectionInfoModal.tsx
  • pages/settings/wallets/ConnectWallet.tsx

📝 Walkthrough

Walkthrough

The PR adjusts insecure-relay alert spacing and moves the returnTo destination notice from the connection-details modal to the wallet connection confirmation area.

Changes

Alert spacing

Layer / File(s) Summary
Insecure-relay alert spacing
components/ConnectionInfoModal.tsx
The insecure-relay warning uses the mb-0 class.

Redirect notice placement

Layer / File(s) Summary
Confirmation redirect notice
pages/settings/wallets/ConnectWallet.tsx
The returnTo notice appears in the confirmation area. ConnectView no longer receives or displays returnTo in the connection-details modal.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • getAlby/go#451: Updates the same connection modal and wallet connection flow.

Suggested reviewers: rolznz

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/connect-redirect-visibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant