Skip to content

update server location hint - #8902

Merged
jigar-f merged 2 commits into
mainfrom
jigar/update-hint-server-location
Jul 9, 2026
Merged

update server location hint#8902
jigar-f merged 2 commits into
mainfrom
jigar/update-hint-server-location

Conversation

@jigar-f

@jigar-f jigar-f commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the description text for the smart routing mode in the server selection feature. The main change is replacing the old, less descriptive string with a new, more informative message that explains how Smart Location works. The new string is also added to the localization files to ensure proper translation support.

User interface improvements:

  • Updated the smart routing mode description in server_selection.dart to use a more detailed and user-friendly message, replacing the previous string reference. [1] [2]

Localization updates:

  • Added a new smart_routing_mode_description string to the English localization file (en.po) with a clear explanation of the Smart Location feature.

Summary by CodeRabbit

  • New Features

    • Added an updated in-app description for “Smart Location,” clarifying that it selects the fastest server and automatically switches as better routes are found.
    • Refreshed the server selection UI wording to use the new description in the relevant screens.
  • Localization

    • Added the new “Smart Location” description text across multiple languages in the app’s translation files (some entries currently display English).

Copilot AI review requested due to automatic review settings July 9, 2026 12:03
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a87ebf74-423e-4ede-8fe1-0f08f6860e48

📥 Commits

Reviewing files that changed from the base of the PR and between 6748a5c and 0e17d3e.

📒 Files selected for processing (19)
  • assets/locales/ar.po
  • assets/locales/bn.po
  • assets/locales/es-cu.po
  • assets/locales/es.po
  • assets/locales/fa.po
  • assets/locales/fr-ca.po
  • assets/locales/fr.po
  • assets/locales/hi.po
  • assets/locales/ms.po
  • assets/locales/my.po
  • assets/locales/ps.po
  • assets/locales/ru.po
  • assets/locales/th.po
  • assets/locales/tk.po
  • assets/locales/tr.po
  • assets/locales/ur.po
  • assets/locales/vi.po
  • assets/locales/zh-Hans.po
  • assets/locales/zh-Hant.po
✅ Files skipped from review due to trivial changes (3)
  • assets/locales/fr.po
  • assets/locales/vi.po
  • assets/locales/hi.po

📝 Walkthrough

Walkthrough

Added a new localized string for Smart Location routing and updated the server selection screen to use that new i18n key in both displayed locations.

Changes

Smart Routing Description Update

Layer / File(s) Summary
Add translation string
assets/locales/*.po
Adds smart_routing_mode_description entries across locale files with the new Smart Location description text.
Switch server selection text
lib/features/vpn/server_selection.dart
Replaces both server selection references to the old description key with smart_routing_mode_description.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: myleshorton

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the main change: updating the server location hint text in the server selection UI and locales.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jigar/update-hint-server-location

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the user-facing description text shown for the “Smart Location” (smart routing) mode in the server selection UI by switching to a new localization key and adding the corresponding English string.

Changes:

  • Replaced the UI string key used for the Smart Location description in the server selection screen.
  • Added a new English gettext entry (smart_routing_mode_description) to en.po.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
lib/features/vpn/server_selection.dart Swaps the displayed Smart Location description to a new i18n key in two UI branches.
assets/locales/en.po Adds the new English translation string for the new i18n key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/features/vpn/server_selection.dart
Comment thread lib/features/vpn/server_selection.dart
Comment thread assets/locales/en.po
@jigar-f

jigar-f commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Small change, pulling it in.

@jigar-f
jigar-f merged commit 9388beb into main Jul 9, 2026
9 checks passed
@jigar-f
jigar-f deleted the jigar/update-hint-server-location branch July 9, 2026 12:27
@coderabbitai coderabbitai Bot mentioned this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants