service/start-odk: fix DB_SSL check in non docker-compose envs - #2064
Merged
Conversation
alxndrsn
commented
Jul 10, 2026
| const stdcombi = []; | ||
|
|
||
| const process = spawn('docker', [ 'compose', 'run', ...args, 'service' ], { cwd:'..' }); | ||
| const process = spawn('docker', [ 'compose', ...args, 'service' ], { cwd:'..' }); |
Contributor
Author
There was a problem hiding this comment.
The new test required a change to where args can be inserted.
alxndrsn
commented
Jul 10, 2026
| "test:nginx:mocha": "NODE_TLS_REJECT_UNAUTHORIZED=0 mocha './nginx/src/mocha/**/*.spec.js' --require ./nginx/src/mocha/mocha.setup.js", | ||
| "test:nginx:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 playwright test", | ||
| "test:service": "mocha ./service.spec.js", | ||
| "test:service": "mocha ./service/service.spec.js", |
Contributor
Author
There was a problem hiding this comment.
This change is just to organise the service tests better, now that these tests span more than one file.
lognaturel
approved these changes
Jul 10, 2026
alxndrsn
commented
Jul 11, 2026
alxndrsn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2063
What has been done to verify that this works as intended?
New test.
Why is this the best possible solution? Were any other approaches considered?
It doesn't change behaviour when using docker compose, but should fix the problem for environments where it's really possible to not have any value for
DB_SSL.How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Fixes a bug.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.