Skip to content

Fix the end of form view#7175

Merged
grzesiek2010 merged 1 commit into
getodk:masterfrom
grzesiek2010:COLLECT-7171
Apr 11, 2026
Merged

Fix the end of form view#7175
grzesiek2010 merged 1 commit into
getodk:masterfrom
grzesiek2010:COLLECT-7171

Conversation

@grzesiek2010

@grzesiek2010 grzesiek2010 commented Apr 10, 2026

Copy link
Copy Markdown
Member

Closes #7171

Why is this the best possible solution? Were any other approaches considered?

We need to use Surface for Text to use theme colors similar to #7061

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This should simply fix the issue.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010
grzesiek2010 marked this pull request as ready for review April 10, 2026 22:27
@grzesiek2010
grzesiek2010 requested a review from seadowg April 10, 2026 22:27
@grzesiek2010
grzesiek2010 merged commit 66dd653 into getodk:master Apr 11, 2026
8 checks passed
@WKobus

WKobus commented Apr 16, 2026

Copy link
Copy Markdown

tested with success

Verified on Android 16

Verified cases:

@dbemke

dbemke commented Apr 16, 2026

Copy link
Copy Markdown

Tested with success

Verified on Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"You are at the end of (form name)" information at the end page has black color in dark mode

4 participants