docs(js): Fix incorrect instrument.mjs filename #12454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YuriyBl is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jan-auer
added a commit
that referenced
this pull request
Jan 28, 2025
…zation-settings * master: (511 commits) docs(cloudflare): several semantic and stylistic fixes in code examples for cloudflare workers (#12482) chore(replay): Clarify network bandwidth and show how to reduce perf impact for mobile SDKs (#12479) chore(replay): Update product docs FAQ (#12474) ref: Drop remaining usage of `<Note>` (#12476) Update debugmeta.mdx (#12436) Fix queue_producer_transaction string termination error in example code (#12463) Adjust for sentry-ruby changes (#12455) Fixed incorrect instrument.mjs filename (#12454) Updating feature flags docs location (#12453) ref: Remove `<Note>` component in favor of using `<Alert>` (#12467) feat: send content feedback plausible events (#12400) docs(native): document how to set attribute on spans/transactions feat(express): Add warning about express v5 (#12465) chore(jira): Add instructions for installing Jira for self-hosted sentry users (#12433) chore: Update Codecov Bundler Plugin Version (#12459) Bump API schema to 421589ca (#12461) fix(platform): Enable scrolling via keyboard buttons (#12460) feat: Update `Expandable` style (#12457) Add Kotlin examples and fix typo in Java and Android Scopes docs (#12458) doc(js): Document how to set attribute on all spans (#12449) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going through the docs for sentry installation on aws lambdas (js), I've noticed that in one place initialization file name is different from the rest (
instrumentation.mjsinstead ofinstrument.mjs), so I changed it to be consistent.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES