Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 27, 2025

Removes the <Note> component in favor of just using <Alert>. They have already been exactly the same, so this is just redundant.

@mydea mydea self-assigned this Jan 27, 2025
@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:08am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Jan 27, 2025 10:08am

@codecov
Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.61MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

@inventarSarah
Copy link
Collaborator

@mydea should we also remove the Note section in Contributing to Docs at the same time? (https://docs.sentry.io/contributing/pages/components/#note)

@mydea
Copy link
Member Author

mydea commented Jan 27, 2025

That should be part of this PR!

@inventarSarah
Copy link
Collaborator

That should be part of this PR!

Yes, you are 100% right -- I missed that!

Looks good to me 👍

@mydea mydea merged commit 4558e3b into master Jan 27, 2025
11 checks passed
@mydea mydea deleted the fn/remove-note branch January 27, 2025 17:12
jan-auer added a commit that referenced this pull request Jan 28, 2025
…zation-settings

* master: (511 commits)
  docs(cloudflare): several semantic and stylistic fixes in code examples for cloudflare workers (#12482)
  chore(replay): Clarify network bandwidth and show how to reduce perf impact for mobile SDKs (#12479)
  chore(replay): Update product docs FAQ (#12474)
  ref: Drop remaining usage of `<Note>` (#12476)
  Update debugmeta.mdx (#12436)
  Fix queue_producer_transaction string termination error in example code (#12463)
  Adjust for sentry-ruby changes (#12455)
  Fixed incorrect instrument.mjs filename (#12454)
  Updating feature flags docs location (#12453)
  ref: Remove `<Note>` component in favor of using `<Alert>` (#12467)
  feat: send content feedback plausible events (#12400)
  docs(native): document how to set attribute on spans/transactions
  feat(express): Add warning about express v5 (#12465)
  chore(jira): Add instructions for installing Jira for self-hosted sentry users (#12433)
  chore: Update Codecov Bundler Plugin Version (#12459)
  Bump API schema to 421589ca (#12461)
  fix(platform): Enable scrolling via keyboard buttons (#12460)
  feat: Update `Expandable` style (#12457)
  Add Kotlin examples and fix typo in Java and Android Scopes docs (#12458)
  doc(js): Document how to set attribute on all spans (#12449)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants