Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 27, 2025

Hmm, it seems #12467 did not catch everything. Probably some search-replace stuff. Now, it should be fully gone, and also removes the actual component code itself!

@mydea mydea self-assigned this Jan 27, 2025
@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:14am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 9:14am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 9:14am

@codecov
Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will decrease total bundle size by 519 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.63MB 344 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.31MB 175 bytes (-0.0%) ⬇️
View changes by path for bundle: sentry-docs-server-cjs
File path Size Change
/[[...path]] 3.07MB 171 bytes (-0.01%)

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the export from mdxComponents needs to be removed that breaks the build!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My scroll finger is gonna need a vacation after this one 💪 Thanks for fixing!

@mydea mydea merged commit e7870b9 into master Jan 28, 2025
11 checks passed
@mydea mydea deleted the fn/remove-more-note branch January 28, 2025 09:39
jan-auer added a commit that referenced this pull request Jan 28, 2025
…zation-settings

* master: (511 commits)
  docs(cloudflare): several semantic and stylistic fixes in code examples for cloudflare workers (#12482)
  chore(replay): Clarify network bandwidth and show how to reduce perf impact for mobile SDKs (#12479)
  chore(replay): Update product docs FAQ (#12474)
  ref: Drop remaining usage of `<Note>` (#12476)
  Update debugmeta.mdx (#12436)
  Fix queue_producer_transaction string termination error in example code (#12463)
  Adjust for sentry-ruby changes (#12455)
  Fixed incorrect instrument.mjs filename (#12454)
  Updating feature flags docs location (#12453)
  ref: Remove `<Note>` component in favor of using `<Alert>` (#12467)
  feat: send content feedback plausible events (#12400)
  docs(native): document how to set attribute on spans/transactions
  feat(express): Add warning about express v5 (#12465)
  chore(jira): Add instructions for installing Jira for self-hosted sentry users (#12433)
  chore: Update Codecov Bundler Plugin Version (#12459)
  Bump API schema to 421589ca (#12461)
  fix(platform): Enable scrolling via keyboard buttons (#12460)
  feat: Update `Expandable` style (#12457)
  Add Kotlin examples and fix typo in Java and Android Scopes docs (#12458)
  doc(js): Document how to set attribute on all spans (#12449)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants