-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(js): Add metrics page #15353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(js): Add metrics page #15353
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 270.41kB (1.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
JPeer264
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing that needs to change (the camelCase one), others are optional
| 1. `browser.name` | ||
| 2. `browser.version` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these extracted in Relay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note 👍
|
|
||
| ### Disabling Metrics | ||
|
|
||
| If you want to disable metrics collection entirely, you can do so by disabling the `_experimental.enableMetrics` flag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused by this; since this is an experimental feature that you need to manually turn on with enableMetrics: true I would assume it's false' by default, so is explicitly setting it to false` necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this in here since we'll change this on monday to the top-level enableMetrics option
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments, looks good!
Co-authored-by: Jan Peer Stöcklmair <jan.peer@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
98a2d04 to
aaf48bd
Compare
…ntry/sentry-docs into docs/span-metrics-examples * 'docs/span-metrics-examples' of https://github.com/getsentry/sentry-docs: (27 commits) Adding logs callout in relevant breadcrumbs docs. (#15432) docs(self-hosted): Troubleshooting guide to invalidate projectconfigs (#15377) docs(js): Add metrics page (#15353) fix encoding for minification (#15429) update instructions for string minification (#15421) getsentry/relay@938582a fix: typos in TanStack Start docs (#15425) feat: Add firebase docs integration (#15310) feat(develop-docs): add index and subpages for Telemetry Buffer (#15424) docs(integration): Update Linear Agent Docs (#15420) feat(cloudflare): Fixed snippet to be cloudflare specific (#15369) chore(aws-lambda): Add troubleshooting section with known issue (#15414) getsentry/relay@5e23f1a docs(size-analysis): Align code boxes and remove vcsInfo links (#15418) feat(develop-docs): Add telemetry buffer page (#15411) Add Composer requirement to PHP platform guide (#15319) Updated link for version compatability (#15311) (WIP) Mtopo27/size analysis docs (#15256) Metrics Product Docs (#15375) ref(develop/spans): Replace `is_remote` with `is_segment` in Span Protocol (#15415) ...
No description provided.