Skip to content

Conversation

@chargome
Copy link
Member

No description provided.

@chargome chargome self-assigned this Oct 30, 2025
@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 7, 2025 9:21pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 7, 2025 9:21pm

@codecov
Copy link

codecov bot commented Oct 30, 2025

Bundle Report

Changes will increase total bundle size by 270.41kB (1.17%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.85MB 270.42kB (2.15%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 90.14kB 850.77kB 11.85% ⚠️
../app/platform-redirect/page.js.nft.json 90.14kB 850.69kB 11.85% ⚠️
../app/sitemap.xml/route.js.nft.json 90.14kB 847.92kB 11.9% ⚠️
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/dkMekRXaGKd0hoELi1eHO/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/dkMekRXaGKd0hoELi1eHO/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/lmzVl-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/lmzVl-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing that needs to change (the camelCase one), others are optional

Comment on lines 21 to 22
1. `browser.name`
2. `browser.version`
Copy link
Member

@cleptric cleptric Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these extracted in Relay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note 👍


### Disabling Metrics

If you want to disable metrics collection entirely, you can do so by disabling the `_experimental.enableMetrics` flag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused by this; since this is an experimental feature that you need to manually turn on with enableMetrics: true I would assume it's false' by default, so is explicitly setting it to false` necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this in here since we'll change this on monday to the top-level enableMetrics option

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments, looks good!

chargome and others added 4 commits November 7, 2025 22:08
chargome and others added 7 commits November 7, 2025 22:08
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
@chargome chargome merged commit 2bfe39a into master Nov 7, 2025
15 of 16 checks passed
@chargome chargome deleted the cg-js-metrics branch November 7, 2025 21:32
codyde added a commit that referenced this pull request Nov 9, 2025
…ntry/sentry-docs into docs/span-metrics-examples

* 'docs/span-metrics-examples' of https://github.com/getsentry/sentry-docs: (27 commits)
  Adding logs callout in relevant breadcrumbs docs. (#15432)
  docs(self-hosted): Troubleshooting guide to invalidate projectconfigs (#15377)
  docs(js): Add metrics page (#15353)
  fix encoding for minification (#15429)
  update instructions for string minification (#15421)
  getsentry/relay@938582a
  fix: typos in TanStack Start docs (#15425)
  feat: Add firebase docs integration (#15310)
  feat(develop-docs): add index and subpages for Telemetry Buffer (#15424)
  docs(integration): Update Linear Agent Docs  (#15420)
  feat(cloudflare): Fixed snippet to be cloudflare specific (#15369)
  chore(aws-lambda): Add troubleshooting section with known issue (#15414)
  getsentry/relay@5e23f1a
  docs(size-analysis): Align code boxes and remove vcsInfo links (#15418)
  feat(develop-docs): Add telemetry buffer page (#15411)
  Add Composer requirement to PHP platform guide (#15319)
  Updated link for version compatability (#15311)
  (WIP) Mtopo27/size analysis docs (#15256)
  Metrics Product Docs (#15375)
  ref(develop/spans): Replace `is_remote` with `is_segment` in Span Protocol (#15415)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants