Skip to content

Conversation

@codyde
Copy link
Contributor

@codyde codyde commented Nov 7, 2025

This change is not typically how we would want to move forward with changes - being that we would normallly focus on making these changes on each SDK.

Breadcrumbs are relatively low impact changes - and the contrent being added is informational.

Making this change wider as an exception.

@codyde codyde requested a review from sfanahata November 7, 2025 23:39
@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 8, 2025 8:59am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 8, 2025 8:59am

@codeowner-assignment codeowner-assignment bot requested review from a team November 7, 2025 23:39
@codecov
Copy link

codecov bot commented Nov 7, 2025

Bundle Report

Changes will increase total bundle size by 9.88kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.6MB 9.88kB (0.08%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/gWiLcT8enbKaGvCWFJ0Kw/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/gWiLcT8enbKaGvCWFJ0Kw/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/OcjDT5JQaHNAXT_dxyzfo/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/OcjDT5JQaHNAXT_dxyzfo/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 3.3kB 764.57kB 0.43%
../app/platform-redirect/page.js.nft.json 3.3kB 764.48kB 0.43%
../app/sitemap.xml/route.js.nft.json 3.3kB 761.71kB 0.43%

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Love the friendly callout.

@codeowner-assignment codeowner-assignment bot requested review from a team November 8, 2025 08:48
@codyde codyde removed request for a team November 8, 2025 08:48
@codeowner-assignment codeowner-assignment bot requested review from a team November 8, 2025 08:48
@codyde codyde removed request for a team November 8, 2025 08:49
@codyde codyde merged commit 31703a1 into master Nov 8, 2025
13 of 14 checks passed
@codyde codyde deleted the feat-logs-focus-over-breadcrumbs branch November 8, 2025 18:20
codyde added a commit that referenced this pull request Nov 9, 2025
…ntry/sentry-docs into docs/span-metrics-examples

* 'docs/span-metrics-examples' of https://github.com/getsentry/sentry-docs: (27 commits)
  Adding logs callout in relevant breadcrumbs docs. (#15432)
  docs(self-hosted): Troubleshooting guide to invalidate projectconfigs (#15377)
  docs(js): Add metrics page (#15353)
  fix encoding for minification (#15429)
  update instructions for string minification (#15421)
  getsentry/relay@938582a
  fix: typos in TanStack Start docs (#15425)
  feat: Add firebase docs integration (#15310)
  feat(develop-docs): add index and subpages for Telemetry Buffer (#15424)
  docs(integration): Update Linear Agent Docs  (#15420)
  feat(cloudflare): Fixed snippet to be cloudflare specific (#15369)
  chore(aws-lambda): Add troubleshooting section with known issue (#15414)
  getsentry/relay@5e23f1a
  docs(size-analysis): Align code boxes and remove vcsInfo links (#15418)
  feat(develop-docs): Add telemetry buffer page (#15411)
  Add Composer requirement to PHP platform guide (#15319)
  Updated link for version compatability (#15311)
  (WIP) Mtopo27/size analysis docs (#15256)
  Metrics Product Docs (#15375)
  ref(develop/spans): Replace `is_remote` with `is_segment` in Span Protocol (#15415)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants