ref: Log warning when fallback binary import fails - #39
Merged
Conversation
Lms24
changed the title
timfish
approved these changes
Aug 4, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes getsentry/sentry-javascript#22970
When users use a non-LTS Node version,
importCppBindingsModule()falls back to importing the binary identifier with an ABI level we don't support. Hence therequirecall crashes with a"Cannot find module"error. This PR try/catches the fallback import and logs a hint that non-LTS versions are not supported. Also changes the signature ofimportCppBindingsModuleto also returnundefined. We already guarded against this but this should make it more apparent.