Skip to content

ref: Log warning when fallback binary import fails #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 1 commit into from
Aug 4, 2026
+9 −3
Merged

ref: Log warning when fallback binary import fails #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const identifier = [platform, arch, stdlib, abi].filter(c => c !== undefined &&
* Imports cpp bindings based on the current platform and architecture.
*/
// eslint-disable-next-line complexity
export function importCppBindingsModule(): PrivateV8CpuProfilerBindings {
export function importCppBindingsModule(): PrivateV8CpuProfilerBindings | undefined {
// If a binary path is specified, use that.
if (env['SENTRY_PROFILER_BINARY_PATH']) {
const envPath = env['SENTRY_PROFILER_BINARY_PATH'];
Expand Down Expand Up @@ -182,10 +182,16 @@ export function importCppBindingsModule(): PrivateV8CpuProfilerBindings {
}
}

return require(`./sentry_cpu_profiler-${identifier}.node`);
try {
return require(`./sentry_cpu_profiler-${identifier}.node`);
} catch (e) {
console.log(`[Profiling] Could not import binary: ${identifier}. Profiling does not work on non-LTS Node.js versions. Detailed Error:`);
console.log(e);
return undefined;
}
}

export const PrivateCpuProfilerBindings: PrivateV8CpuProfilerBindings = importCppBindingsModule();
export const PrivateCpuProfilerBindings: PrivateV8CpuProfilerBindings | undefined = importCppBindingsModule();

class Bindings implements V8CpuProfilerBindings {
public startProfiling(name: string): void {
Expand Down
Loading