test(e2e): Fix type error in nextjs ai-error tests - #22978
Merged
chargome merged 1 commit intoAug 4, 2026
Conversation
`value?.includes(...)` yields `boolean | undefined`, which widens to `Promise<boolean | undefined>` in the async callback and is not assignable to `waitForError`'s `boolean | Promise<boolean>`. Next 16.3 made `experimental.useTypeScriptCli` the default, and that path does not filter diagnostics in `*.test.ts` the way the previous TypeScript-API path did, so this pre-existing error now fails `next build`. Fixes #22973 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Aug 4, 2026
This was referenced Aug 4, 2026
chargome
added a commit
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a build-time type error that breaks the nextjs-16 canary and latest E2E jobs.
Next 16.3 flipped
experimental.useTypeScriptClitotrueby default, and unlike the previous TypeScript-API path it does not filter diagnostics in*.(spec|test).*files, so this pre-existing error now failsnext build.closes #22973
closes #22974