fix: Include query string and fragment in url.full span attribute#6861
Draft
sentrivana wants to merge 1 commit into
Draft
fix: Include query string and fragment in url.full span attribute#6861sentrivana wants to merge 1 commit into
url.full span attribute#6861sentrivana wants to merge 1 commit into
Conversation
The `url.full` attribute was only being set to the base URL (scheme + host + path), omitting query string and fragment. This affected aiohttp (server and client), httpx, httpx2, and WSGI integrations. ASGI and Quart were already correct. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sentrivana
changed the title
url.full span attribute
Contributor
Codecov Results 📊✅ 92197 passed | ⏭️ 6304 skipped | Total: 98501 | Pass Rate: 93.6% | Execution Time: 310m 18s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 97.37%. Project has 2479 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.70% 89.70% —%
==========================================
Files 193 193 —
Lines 24039 24070 +31
Branches 8354 8378 +24
==========================================
+ Hits 21562 21591 +29
- Misses 2477 2479 +2
- Partials 1386 1389 +3Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
url.fullspan attribute was only being set to the base URL (scheme + host + path), omitting query string and fragmentWill wait with merging until the
DataCollectionstack is in, to not make rebasing it a nightmare.Closes #6860