perf!(log): Box RecordMapping::Event - #1269
Merged
szokeasaurusrex merged 3 commits intoJul 27, 2026
Merged
Conversation
szokeasaurusrex
changed the title
RecordMapping's fields (log integration)RecordMapping's fields
szokeasaurusrex
force-pushed
the
recordmapping-log
branch
from
July 27, 2026 09:44
3fcb078 to
b6bec31
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/disallow-allow
branch
from
July 27, 2026 09:44
29e2ab6 to
c6bfa26
Compare
szokeasaurusrex
changed the title
RecordMapping's fieldsRecordMapping's fields
This allows us to fix the suppressed `clippy::large_enum_variant` while preserving future API flexibility. I see little reason to keep the enum variants publicly exposed. The type needs to be public because other public APIs use it, but I doubt any users rely on knowing the enum variants.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/disallow-allow
branch
from
July 27, 2026 12:10
c6bfa26 to
09823b7
Compare
szokeasaurusrex
force-pushed
the
recordmapping-log
branch
from
July 27, 2026 12:10
b6bec31 to
49bb95b
Compare
szokeasaurusrex
marked this pull request as ready for review
July 27, 2026 12:11
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
marked this pull request as draft
July 27, 2026 12:14
szokeasaurusrex
changed the title
RecordMapping's fieldsRecordMapping::Event
szokeasaurusrex
marked this pull request as ready for review
July 27, 2026 12:25
| //! // Send both an event and a breadcrumb for errors | ||
| //! vec
alexander-alderman-webb
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the suppressed
clippy::large_enum_variantby putting Event in aBox