Skip to content

Replay count endpoint: validate required parameter #85606

@sentry

Description

@sentry

The endpoint requires the query parameter, otherwise it calls several functions deep and fails on calling len(query).

Solution brainstorm: Validate query exists at the API entrypoint, otherwise return 400 indicating missing param

Sentry Issue: SENTRY-2Z7Z

TypeError: object of type 'NoneType' has no len()
(11 additional frame(s) were not displayed)
...
  File "sentry/replays/endpoints/organization_replay_count.py", line 95, in get
    replay_counts = get_replay_counts(
  File "sentry/replays/usecases/replay_counts.py", line 37, in get_replay_counts
    replay_ids_mapping = _get_replay_id_mappings(query, snuba_params, data_source)
  File "sentry/replays/usecases/replay_counts.py", line 72, in _get_replay_id_mappings
    select_column, column_value = _get_select_column(query)
  File "sentry/replays/usecases/replay_counts.py", line 162, in _get_select_column
    parsed_query = parse_search_query(query)
  File "sentry/api/event_search.py", line 1326, in parse_search_query
    tree = event_search_grammar.parse(query)

Metadata

Metadata

Assignees

No one assigned

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions