Skip to content

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Feb 21, 2025

Fixes SENTRY-2Z7Z
Closes #85606

@aliu39 aliu39 requested a review from a team as a code owner February 21, 2025 20:18
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 21, 2025
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍🏼

@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/replays/usecases/replay_counts.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #85677      +/-   ##
==========================================
+ Coverage   87.85%   87.86%   +0.01%     
==========================================
  Files        9672     9677       +5     
  Lines      547439   548029     +590     
  Branches    21383    21383              
==========================================
+ Hits       480978   481553     +575     
- Misses      66152    66167      +15     
  Partials      309      309              

@aliu39 aliu39 merged commit bc5cfde into master Feb 24, 2025
48 of 49 checks passed
@aliu39 aliu39 deleted the aliu/replay-count-validate branch February 24, 2025 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replay count endpoint: validate required parameter

3 participants