ref(uptime): Rename detectors module to autodetect by evanpurkhiser · Pull Request #101534 · getsentry/sentry

evanpurkhiser · 2025-10-15T18:17:50Z

Renames the uptime.detectors module to uptime.autodetect to avoid
confusion with the workflow engine's detector concept.

Changes:

Renamed src/sentry/uptime/detectors/ → src/sentry/uptime/autodetect/
Renamed tests/sentry/uptime/detectors/ → tests/sentry/uptime/autodetect/
Renamed functions: detect_base_url_for_project → autodetect_base_url_for_project
Renamed functions: should_detect_for_* → should_autodetect_for_*
Updated all import statements and mock.patch references

IMPORTANT - NOT CHANGED (to avoid breaking production):

Celery task names remain unchanged to prevent breaking in-flight tasks:
- "sentry.uptime.detectors.tasks.schedule_detections"
- "sentry.uptime.detectors.tasks.process_detection_bucket"
- "sentry.uptime.detectors.tasks.process_organization_url_ranking"
Redis keys remain unchanged (11 keys) to prevent breaking lookups
Lock name "uptime.detection.schedule_detections" remains unchanged
Django setting SENTRY_UPTIME_DETECTOR_CLUSTER remains unchanged
Feature flags remain unchanged
Metrics remain unchanged to avoid breaking dashboards

evanpurkhiser · 2025-10-15T18:19:04Z

 @instrumented_task(
    name="sentry.uptime.detectors.tasks.schedule_detections",
    namespace=uptime_tasks,
    processing_deadline_duration=60,
 )
-def schedule_detections():
+def schedule_autodetections():


@markstory Just want to double triple check here.

I've renamed this module and I've renamed this function. However the @instrumented_task annotation has NOT changed. This IS safe correct?

Yes those changes are both safe. The task name and namespace attributes are what is serialized into activations and need to be consistent across deploys.

evanpurkhiser · 2025-10-15T18:19:31Z

                metrics.incr("uptime.detectors.scheduler.scheduled_bucket")
                last_processed = last_processed + timedelta(minutes=1)
-                process_detection_bucket.delay(last_processed.isoformat())
+                process_autodetection_bucket.delay(last_processed.isoformat())


@markstory when it dispatches this task, it's using the name from the annotation to dispatch the queued task right

when it dispatches this task, it's using the name from the annotation to dispatch the queued task right

Correct.

sentry/src/sentry/taskworker/task.py

Lines 223 to 234 in 3ff36a4

return TaskActivation(

id=uuid4().hex,

namespace=self._namespace.name,

taskname=self.name,

headers=headers,

parameters=parameters_str,

retry_state=self._create_retry_state(),

received_at=received_at,

processing_deadline_duration=processing_deadline,

expires=expires,

delay=countdown,

)

Is what is stored in kafka when a task is spawned.

seer-by-sentry · 2025-10-15T18:22:52Z

    get_candidate_projects_for_org,
    get_candidate_urls_for_project,
    get_organization_bucket,
-    should_detect_for_organization,
-    should_detect_for_project,
+    should_autodetect_for_organization,
+    should_autodetect_for_project,
 )
 from sentry.uptime.subscriptions.subscriptions import (
    create_uptime_detector,


Potential bug: The TASKWORKER_IMPORTS configuration contains a stale import path, "sentry.uptime.detectors.tasks", which will cause worker processes to crash on startup with a ModuleNotFoundError.

Description: The module sentry.uptime.detectors.tasks was moved to sentry.uptime.autodetect.tasks, but the TASKWORKER_IMPORTS tuple in src/sentry/conf/server.py was not updated. When a taskworker process starts, it calls app.load_modules(), which iterates through TASKWORKER_IMPORTS and imports each module. The attempt to import the now non-existent path "sentry.uptime.detectors.tasks" will raise a ModuleNotFoundError, causing the worker process to crash on startup and preventing any background tasks from running.

Suggested fix: Update the stale import path in src/sentry/conf/server.py. Change "sentry.uptime.detectors.tasks" to "sentry.uptime.autodetect.tasks" within the TASKWORKER_IMPORTS tuple.
_{severity: 0.95, confidence: 1.0}

_{Did we get this right? 👍 / 👎 to inform future reviews.}

I think it's right about this

oh I thought I fixed this, let me double check

It's here right? https://github.com/getsentry/sentry/pull/101534/files#diff-866fbc2da71a688b0a929236b2c864dfa8935d4a6423321d2d97a28337c6e6e8R919

codecov · 2025-10-15T18:23:33Z

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/uptime/autodetect/tasks.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #101534   +/-   ##
========================================
  Coverage   80.97%    80.97%           
========================================
  Files        8706      8706           
  Lines      386918    386918           
  Branches    24520     24520           
========================================
  Hits       313315    313315           
  Misses      73252     73252           
  Partials      351       351

Renames the uptime.detectors module to uptime.autodetect to avoid confusion with the workflow engine's detector concept. Changes: - Renamed src/sentry/uptime/detectors/ → src/sentry/uptime/autodetect/ - Renamed tests/sentry/uptime/detectors/ → tests/sentry/uptime/autodetect/ - Renamed functions: detect_base_url_for_project → autodetect_base_url_for_project - Renamed functions: should_detect_for_* → should_autodetect_for_* - Updated all import statements and mock.patch references IMPORTANT - NOT CHANGED (to avoid breaking production): - Celery task names remain unchanged to prevent breaking in-flight tasks: * "sentry.uptime.detectors.tasks.schedule_detections" * "sentry.uptime.detectors.tasks.process_detection_bucket" * "sentry.uptime.detectors.tasks.process_organization_url_ranking" - Redis keys remain unchanged (11 keys) to prevent breaking lookups - Lock name "uptime.detection.schedule_detections" remains unchanged - Django setting SENTRY_UPTIME_DETECTOR_CLUSTER remains unchanged - Feature flags remain unchanged - Metrics remain unchanged to avoid breaking dashboards

markstory · 2025-10-15T20:55:20Z

 @instrumented_task(
    name="sentry.uptime.detectors.tasks.schedule_detections",
    namespace=uptime_tasks,
    processing_deadline_duration=60,
 )
-def schedule_detections():
+def schedule_autodetections():


Yes those changes are both safe. The task name and namespace attributes are what is serialized into activations and need to be consistent across deploys.

markstory · 2025-10-15T20:56:49Z

                metrics.incr("uptime.detectors.scheduler.scheduled_bucket")
                last_processed = last_processed + timedelta(minutes=1)
-                process_detection_bucket.delay(last_processed.isoformat())
+                process_autodetection_bucket.delay(last_processed.isoformat())


when it dispatches this task, it's using the name from the annotation to dispatch the queued task right

Correct.

sentry/src/sentry/taskworker/task.py

Lines 223 to 234 in 3ff36a4

return TaskActivation(

id=uuid4().hex,

namespace=self._namespace.name,

taskname=self.name,

headers=headers,

parameters=parameters_str,

retry_state=self._create_retry_state(),

received_at=received_at,

processing_deadline_duration=processing_deadline,

expires=expires,

delay=countdown,

)

Is what is stored in kafka when a task is spawned.

evanpurkhiser · 2025-10-15T21:20:39Z

Going to wait until tomorrow to merge

evanpurkhiser requested review from a team as code owners October 15, 2025 18:17

evanpurkhiser requested review from wedamija and removed request for a team October 15, 2025 18:17

github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 15, 2025

evanpurkhiser commented Oct 15, 2025

View reviewed changes

vercel Bot deployed to Preview October 15, 2025 18:19 View deployment

seer-by-sentry Bot reviewed Oct 15, 2025

View reviewed changes

evanpurkhiser force-pushed the evanpurkhiser/ref-uptime-rename-detectors-module-to-autodetect branch from 3f2bd7e to 6427973 Compare October 15, 2025 18:37

vercel Bot deployed to Preview October 15, 2025 18:42 View deployment

evanpurkhiser force-pushed the evanpurkhiser/ref-uptime-rename-detectors-module-to-autodetect branch from 6427973 to fb485d3 Compare October 15, 2025 20:04

evanpurkhiser requested a review from a team as a code owner October 15, 2025 20:04

vercel Bot deployed to Preview October 15, 2025 20:06 View deployment

markstory approved these changes Oct 15, 2025

View reviewed changes

wedamija approved these changes Oct 15, 2025

View reviewed changes

evanpurkhiser merged commit fc769a4 into master Oct 16, 2025
67 checks passed

evanpurkhiser deleted the evanpurkhiser/ref-uptime-rename-detectors-module-to-autodetect branch October 16, 2025 15:54

github-actions Bot locked and limited conversation to collaborators Nov 1, 2025

	return TaskActivation(
	id=uuid4().hex,
	namespace=self._namespace.name,
	taskname=self.name,
	headers=headers,
	parameters=parameters_str,
	retry_state=self._create_retry_state(),
	received_at=received_at,
	processing_deadline_duration=processing_deadline,
	expires=expires,
	delay=countdown,
	)

Uh oh!

Conversation

evanpurkhiser commented Oct 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seer-by-sentry Bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evanpurkhiser commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 15, 2025 •

edited

Loading