fix(debug_files): Do not add .dSYM extension to mach-o files
#102012
Merged
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are binaries, not dSYM directories, so it is inaccurate and misleading to add the `.dSYM` extension. Fixes #102011 Fixes ENG-5763
github-actions
bot
added
the
Scope: Backend
lcian
approved these changes
Oct 24, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Oct 24, 2025
In #102012, we removed the incorrect `.dSYM` extensions from downloaded Mach-O debug files. However, as @jan-auer noted, these debug files potentially share the same debug ID as the corresponding executable or dynamic library. Therefore, we should add a file extension to the debug files to distinguish them. We are picking `.debug` to align with the extension used for `elf` files.
szokeasaurusrex
added a commit
that referenced
this pull request
Oct 24, 2025
) In #102012, we removed the incorrect `.dSYM` extensions from downloaded Mach-O debug files. However, as @jan-auer noted, these debug files potentially share the same debug ID as the corresponding executable or dynamic library. Therefore, we should add a file extension to the debug files to distinguish them. We are picking `.debug` to align with the extension used for `elf` files.
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 28, 2025
These files are binaries, not dSYM directories, so it is inaccurate and misleading to add the `.dSYM` extension. Fixes #102011 Fixes ENG-5763
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 28, 2025
) In #102012, we removed the incorrect `.dSYM` extensions from downloaded Mach-O debug files. However, as @jan-auer noted, these debug files potentially share the same debug ID as the corresponding executable or dynamic library. Therefore, we should add a file extension to the debug files to distinguish them. We are picking `.debug` to align with the extension used for `elf` files.
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
These files are binaries, not dSYM directories, so it is inaccurate and misleading to add the `.dSYM` extension. Fixes #102011 Fixes ENG-5763
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
) In #102012, we removed the incorrect `.dSYM` extensions from downloaded Mach-O debug files. However, as @jan-auer noted, these debug files potentially share the same debug ID as the corresponding executable or dynamic library. Therefore, we should add a file extension to the debug files to distinguish them. We are picking `.debug` to align with the extension used for `elf` files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are binaries, not dSYM directories, so it is inaccurate and misleading to add the
.dSYMextension.Fixes #102011
Fixes ENG-5763