Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/models/debugfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def file_extension(self) -> str:
if self.file_format == "breakpad":
return ".sym"
if self.file_format == "macho":
return "" if self.file_type == "exe" else ".dSYM"
return ""
if self.file_format == "proguard":
return ".txt"
if self.file_format == "elf":
Expand Down
20 changes: 20 additions & 0 deletions tests/sentry/models/test_debugfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,26 @@ def test_file_extension_dartsymbolmap(self) -> None:
# Verify that file_extension returns .json
assert dif.file_extension == ".json"

def test_file_extension_macho(self) -> None:
"""Test that macho files return empty file extension."""
file = File.objects.create(
name="foo",
type="project.dif",
headers={"Content-Type": "application/x-mach-binary"},
)

dif = ProjectDebugFile.objects.create(
file=file,
checksum="test-checksum",
object_name="foo",
cpu_name="x86_64",
project_id=self.project.id,
debug_id="b8e43a-f242-3d73-a453-aeb6a777ef75",
data={"type": "dbg"},
)

assert dif.file_extension == ""


class CreateDebugFileTest(APITestCase):
@property
Expand Down
Loading