ref(objectstore): Stop using sentry.options internally #102080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lcian
commented
Oct 24, 2025
|
|
||
|
|
||
| class Client: | ||
| _default_compression: Compression |
There was a problem hiding this comment.
added to stop pyright from complaining, it considered this to be a str
Swatinem
reviewed
Oct 28, 2025
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Swatinem
approved these changes
Oct 28, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 29, 2025
|
revert failed (conflict? already reverted?) -- check the logs |
lcian
added a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a required first param
objectstore_base_urltoobjectstore.ClientBuilder.Stops using
sentry.optionsinternally, in preparation to move this module to its own package, and just use it in__init__.pyto initializeattachments, so that other modules can keep using it without any changes.