fix(objectstore): Partially revert #102080 #102354
Merged
+11
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-fish
approved these changes
Oct 29, 2025
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102354 +/- ##
===========================================
+ Coverage 80.16% 80.95% +0.78%
===========================================
Files 8800 8799 -1
Lines 389979 389938 -41
Branches 24817 24817
===========================================
+ Hits 312646 315682 +3036
+ Misses 76959 73882 -3077
Partials 374 374 |
shashjar
approved these changes
Oct 29, 2025
armenzg
added a commit
that referenced
this pull request
Oct 31, 2025
This was removed in #102354 during an incident but Dan's change has been merged since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert #102080.
In particular the usage of the options.
It was causing
sentry-options-automatorto fail for a currently unknown reason, see INC-1478.