feat(aci): add hits to workflow group history response header#102439
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| self.user, | ||
| WorkflowGroupHistorySerializer(), | ||
| ) | ||
| assert resp["X-Hits"] == "4" |
Contributor
There was a problem hiding this comment.
Bug: Grouped Results Mismatch Expected Hits
The X-Hits assertion expects "4", but the query groups WorkflowFireHistory records by group. The test data contains two distinct groups, so X-Hits correctly reports "2" grouped results, not the 4 individual records.
Additional Locations (1)
malwilley
approved these changes
Oct 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102439 +/- ##
===========================================
+ Coverage 75.54% 80.90% +5.36%
===========================================
Files 8819 8825 +6
Lines 389819 389983 +164
Branches 24799 24799
===========================================
+ Hits 294475 315509 +21034
+ Misses 94982 74112 -20870
Partials 362 362 |
isabellaenriquez
pushed a commit
that referenced
this pull request
Oct 31, 2025
adds X-Hits and X-Max-Hits to the response headers so that we know how many objects the full query contains, even if the response itself is paginated, so we can display the count in the UI in the pagination caption
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
adds X-Hits and X-Max-Hits to the response headers so that we know how many objects the full query contains, even if the response itself is paginated, so we can display the count in the UI in the pagination caption
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
adds X-Hits and X-Max-Hits to the response headers so that we know how many objects the full query contains, even if the response itself is paginated, so we can display the count in the UI in the pagination caption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds X-Hits and X-Max-Hits to the response headers so that we know how many objects the full query contains, even if the response itself is paginated, so we can display the count in the UI in the pagination caption