fix(types): Replace TypedDict inheritance with Protocol to avoid mypy crash #102605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the mpy crash error
AssertionError: Must not defer during final iterationonsrc/sentry/deletions.The recent change to reference
ActorSerializerResponseinstead ofUserSerializerResponseintroduced a new complex TypedDict to resolve in the inheritance chain, causing mypy to run out of iterations.This bandaid fix skips the resolution
WebhookGroupResponse-->BaseGroupSerializerResponse-->ActorSerializerResponse. Runtime behavior is identical, although we do lose type information. Another alternative solution is movingActorSerializerResponseto a module outside of the SCC (e.g. touser.py).Ideally we'd like to refactor the wildcard imports in
src/sentry/api/serializers/models/__init__.py(creates a 2000+ module SCC).