Skip to content

fix(types): Replace TypedDict inheritance with Protocol to avoid mypy crash #102605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix(types): Replace TypedDict inheritance with Protocol to avoid mypy crash #102605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/sentry/sentry_apps/tasks/sentry_apps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from collections import defaultdict
from collections.abc import Mapping, Sequence
from datetime import datetime
from typing import Any, SupportsInt, cast
from typing import Any, Protocol, SupportsInt, cast

import sentry_sdk
from django.urls import reverse
Expand Down Expand Up @@ -149,7 +149,9 @@ def _webhook_event_data(
return event_context


class WebhookGroupResponse(BaseGroupSerializerResponse):
# inherits from BaseGroupSerializerResponse
# we use protocol instead of TypedDict inheritance to avoid mypy crash in SCC
class WebhookGroupResponse(Protocol):
web_url: str
project_url: str
url: str
Expand All @@ -158,14 +160,13 @@ class WebhookGroupResponse(BaseGroupSerializerResponse):
def _webhook_issue_data(
group: Group, serialized_group: BaseGroupSerializerResponse
) -> WebhookGroupResponse:

webhook_payload = WebhookGroupResponse(
url=group.get_absolute_api_url(),
web_url=group.get_absolute_url(),
project_url=group.project.get_absolute_url(),
webhook_payload = {
"url": group.get_absolute_api_url(),
"web_url": group.get_absolute_url(),
"project_url": group.project.get_absolute_url(),
**serialized_group,
)
return webhook_payload
}
return cast(WebhookGroupResponse, webhook_payload)


@instrumented_task(
Expand Down
Loading