Skip to content

Conversation

@malwilley
Copy link
Member

This is a refactor that shouldn't change any behavior. The intention is to make the monitor list pages more similar to the detail/form components where you can compose some set of common components to make a custom list view. Currently each detector type is rendering the same form with different context values, but this PR removes most of the context configuration and replaces it with props on the new common components.

This will allow for crons and uptime to start displaying extra UI elements on their list view pages, but still use the same header/table/etc that the other pages do.

@malwilley malwilley requested a review from a team as a code owner November 6, 2025 00:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 6, 2025
* Additional columns to render after the default columns and before the visualization column.
* These appear to the right of the default columns and to the left of the visualization.
*/
additionalColumns?: MonitorListAdditionalColumn[];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed most of the config form this context, but kept the table column customizations for now since those are more difficult to split out.

import {useWorkflowEngineFeatureGate} from 'sentry/components/workflowEngine/useWorkflowEngineFeatureGate';

export default function MonitorViewContainer() {
useWorkflowEngineFeatureGate({redirect: true});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm everything under monitors is gated now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that should be what we want right?

@codecov
Copy link

codecov bot commented Nov 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12351 1 12350 10
View the top 1 failed test(s) by shortest run time
AutomationsList bulk actions shows option to select all query results when page is selected
Stack Traces | 3.34s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: "....../organizations/org-slug/workflows/", ObjectContaining {"query": {"id": undefined, "project": [], "query": "action:slack"}}
Received: "....../organizations/org-slug/workflows/", {"error": [Function error], "method": "DELETE", "query": {"id": undefined, "project": [1], "query": "action:slack"}, "success": [Function success]}

Number of calls: 1

Ignored nodes: comments, script, style
...
    at toHaveBeenCalledWith (.../views/automations/list.spec.tsx:458:31)
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/node_modules/.pnpm/jsdom@26.1..../jsdom/browser/Window.js:579:19)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@malwilley malwilley enabled auto-merge (squash) November 6, 2025 18:16
@malwilley malwilley merged commit 9350390 into master Nov 6, 2025
47 checks passed
@malwilley malwilley deleted the malwilley/ref/detector-list-common-comp branch November 6, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants