-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(aci): Add common components for monitor list views #102842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * Additional columns to render after the default columns and before the visualization column. | ||
| * These appear to the right of the default columns and to the left of the visualization. | ||
| */ | ||
| additionalColumns?: MonitorListAdditionalColumn[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed most of the config form this context, but kept the table column customizations for now since those are more difficult to split out.
| import {useWorkflowEngineFeatureGate} from 'sentry/components/workflowEngine/useWorkflowEngineFeatureGate'; | ||
|
|
||
| export default function MonitorViewContainer() { | ||
| useWorkflowEngineFeatureGate({redirect: true}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to confirm everything under monitors is gated now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that should be what we want right?
…tor-list-common-comp
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This is a refactor that shouldn't change any behavior. The intention is to make the monitor list pages more similar to the detail/form components where you can compose some set of common components to make a custom list view. Currently each detector type is rendering the same form with different context values, but this PR removes most of the context configuration and replaces it with props on the new common components.
This will allow for crons and uptime to start displaying extra UI elements on their list view pages, but still use the same header/table/etc that the other pages do.