Skip to content

Conversation

@mifu67
Copy link
Contributor

@mifu67 mifu67 commented Nov 10, 2025

  • Set metric issue ingest/post-process flags to true so that metric issues can work for self-hosted
  • Tie metric issue visibility to the UI flag so that rollout is smooth
  • Tie new links to the UI flag

@mifu67 mifu67 requested review from a team and wedamija November 10, 2025 19:36
@mifu67 mifu67 requested review from a team as code owners November 10, 2025 19:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 10, 2025
},
)

@classmethod
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wedamija wanted to confirm that this is valid!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set released to True instead on the grouptype?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot, because the UI should not be visible yet :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, so we want to enable this in self-hosted?

Tbh, I wonder if we should set that feature flags we generate here to true in the self hosted config, instead of hardcoding true here. But if you plan to fully release it soon, it could be fine.

Why does this need to be enabled in self-hosted like this though? The issues won't be visible in the ui, so what's the value in allowing these other backend parts to run there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current metric alerts are single processing through the workflow engine, so they will not work if metric issues are not not enabled. ACI is supposed to release soon, but I think either method is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if you're planning to fully release this soon then I'm ok with this. Just make sure to clean up these methods later after you set released = True

@malwilley malwilley linked an issue Nov 10, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
29556 1 29555 243
View the top 1 failed test(s) by shortest run time
tests.sentry.workflow_engine.test_integration.TestWorkflowEngineIntegrationFromIssuePlatform::test_workflow_engine__workflows__no_flag
Stack Traces | 5.93s run time
#x1B[1m#x1B[.../sentry/workflow_engine/test_integration.py#x1B[0m:191: in test_workflow_engine__workflows__no_flag
    mock_process_workflow.assert_not_called()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:938: in assert_not_called
    raise AssertionError(msg)
#x1B[1m#x1B[31mE   AssertionError: Expected 'apply_async' to not have been called. Called 1 times.#x1B[0m
#x1B[1m#x1B[31mE   Calls: [call(kwargs={'project_id': 4557090484387842, 'event_id': 'ec3aa6436959434eb3eeb87624830606', 'occurrence_id': '77bcc0e93ae140ec9d3e9d340173efb5', 'group_id': 652, 'group_state': {'id': 652, 'is_new': False, 'is_regression': False, 'is_new_group_environment': True}, 'has_reappeared': True, 'has_escalated': False, 'start_timestamp_seconds': 1762804104.8424149}, headers={'sentry-propagate-traces': False})].#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mifu67 mifu67 merged commit c0d6ba7 into master Nov 11, 2025
65 checks passed
@mifu67 mifu67 deleted the mifu67/aci/flag-fixes branch November 11, 2025 00:12
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
- Set metric issue ingest/post-process flags to true so that metric
issues can work for self-hosted
- Tie metric issue visibility to the UI flag so that rollout is smooth
- Tie new links to the UI flag
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
- Set metric issue ingest/post-process flags to true so that metric
issues can work for self-hosted
- Tie metric issue visibility to the UI flag so that rollout is smooth
- Tie new links to the UI flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alerts on Number of Errors does not work

4 participants