fix(aci): Display % as suffix for % changed #103203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed the resolution field
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| flexibleControlStateSize | ||
| placeholder="0" | ||
| suffix={thresholdSuffix} | ||
| suffix={detectionType === 'percent' ? '%' : thresholdSuffix} |
Contributor
There was a problem hiding this comment.
Bug: Alert Resolution Validation Flaw
The resolution threshold field now displays a % suffix for 'percent' detection types, but validateResolutionThreshold only validates 'static' detection types (line 35 checks detectionType !== 'static' and returns empty array). This means percent-based resolution thresholds bypass validation entirely, allowing invalid threshold comparisons that could cause incorrect alert resolution behavior.
malwilley
approved these changes
Nov 12, 2025
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Missed the resolution field
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Missed the resolution field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the resolution field