fix(crons): Fix MockCheckInTimeline positioning to match real timeline behavior #103264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e behavior The mock timeline was calculating positions incorrectly, causing misalignment with the grid lines. This fix makes it match how the real CheckInTimeline positions ticks. Key changes: 1. Use `periodStart` instead of `start` (which is underscanStart) as the base for timestamp calculations 2. Add `startOffset` (underscanWidth) to all positions to account for the underscan area on the left 3. Use `elapsedMinutes` from the config for consistency with grid calculations 4. Use `timelineWidth` which excludes the underscan width This matches the positioning logic in mergeBuckets where ticks are positioned relative to the usable timeline area, not the full container width.
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Nov 12, 2025
evanpurkhiser
deleted the
evanpurkhiser/fix-crons-fix-mockcheckintimeline-positioning-to-match-real-timeline-behavior
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…e behavior (#103264) The mock timeline was calculating positions incorrectly, causing misalignment with the grid lines. This fix makes it match how the real CheckInTimeline positions ticks. Key changes: 1. Use `periodStart` instead of `start` (which is underscanStart) as the base timestamp calculations 2. Add `startOffset` (underscanWidth) to all positions to account for the underscan area on the left 3. Use `elapsedMinutes` from the config for consistency with grid calculations 4. Use `timelineWidth` which excludes the underscan width This matches the positioning logic in mergeBuckets where ticks are positioned relative to the usable timeline area, not the full container width.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mock timeline was calculating positions incorrectly, causing misalignment
with the grid lines. This fix makes it match how the real CheckInTimeline
positions ticks.
Key changes:
periodStartinstead ofstart(which is underscanStart) as the basefor timestamp calculations
startOffset(underscanWidth) to all positions to account for theunderscan area on the left
elapsedMinutesfrom the config for consistency with grid calculationstimelineWidthwhich excludes the underscan widthThis matches the positioning logic in mergeBuckets where ticks are positioned
relative to the usable timeline area, not the full container width.