feat(aci): redirect rules to automations with UI FF #103322
Conversation
github-actions
bot
added
the
Scope: Frontend
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| return children; |
There was a problem hiding this comment.
Bug: New UI Fails, Old Interface Returns
When the workflow-engine-ui feature flag is enabled and the API request completes without data (due to failure or missing workflow mapping), the component falls through to render the original alert rules UI. This creates inconsistent behavior where users with the feature flag enabled may still see the old UI when the API fails, rather than being handled explicitly with an error state or alternative redirect.
| return cloneElement(children, props); | ||
| } | ||
|
|
||
| return children; |
There was a problem hiding this comment.
Bug: Child routes not rendered without Outlet component
The WorkflowEngineRedirectWithData component attempts to render child routes by cloning the children prop, but in React Router v6, nested routes require using the <Outlet /> component instead. The current code checks isValidElement(children) which will be false for route configurations, causing it to return the raw children array which won't render anything. When redirect conditions aren't met (e.g., feature flag disabled or API returns null), the child route components won't be displayed, breaking the normal alert rule pages.
redirects issue alert specific routes to the appropriate automation pages