groupstore: refactor reduce calls from On^2 to On #103541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Nov 18, 2025
Contributor
|
Nice |
Merged
TkDodo
reviewed
Nov 19, 2025
Comment on lines
+153
to
+157
| const itemsById: Record<string, Item> = items.reduce((acc, item) => { | ||
| // @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message | ||
| acc[item.id] = item; | ||
| return acc; | ||
| }, {}); |
Collaborator
There was a problem hiding this comment.
quick follow up:
we don’t need the ts-expect-error if we “type” reduce itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spreading when we iterate over each item will cause quadratic runtime as the accumulator object is iterated for each item.