Skip to content

groupstore: refactor reduce calls from On^2 to On #103541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

groupstore: refactor reduce calls from On^2 to On #103541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions static/app/stores/groupStore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,18 +150,19 @@ const storeConfig: GroupStoreDefinition = {
},

mergeItems(items: Item[]) {
const itemsById = items.reduce((acc, item) => ({...acc, [item.id]: item}), {});
const itemsById: Record<string, Item> = items.reduce((acc, item) => {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
acc[item.id] = item;
return acc;
}, {});
Comment on lines +153 to +157
Copy link
Collaborator

@TkDodo TkDodo Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick follow up:

we don’t need the ts-expect-error if we “type” reduce itself


// Merge these items into the store and return a mapping of any that aren't already in the store
this.items.forEach((item, itemIndex) => {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
if (itemsById[item.id]) {
this.items[itemIndex] = {
...item,
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
...itemsById[item.id],
};
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
delete itemsById[item.id];
}
});
Expand All @@ -188,9 +189,12 @@ const storeConfig: GroupStoreDefinition = {
*/
addToFront(items) {
items = toArray(items);
const itemMap = items.reduce((acc, item) => ({...acc, [item.id]: item}), {});
const itemMap: Record<string, Item> = items.reduce((acc, item) => {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
acc[item.id] = item;
return acc;
}, {});

// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
this.items = [...items, ...this.items.filter(item => !itemMap[item.id])];

this.updateItems(items.map(item => item.id));
Expand Down Expand Up @@ -484,10 +488,10 @@ const storeConfig: GroupStoreDefinition = {

onPopulateStats(itemIds, response) {
// Organize stats by id
const groupStatsMap = response.reduce<Record<string, GroupStats>>(
(map, stats) => ({...map, [stats.id]: stats}),
{}
);
const groupStatsMap = response.reduce<Record<string, GroupStats>>((map, stats) => {
map[stats.id] = stats;
return map;
}, {});

this.items.forEach((item, idx) => {
if (itemIds?.includes(item.id)) {
Expand Down
Loading