ref(crons): Disable mute button when monitor has no environments (stage 5) #103568
Conversation
[NEW-564: There needs to be some way to mute the entire cron detector](https://linear.app/getsentry/issue/NEW-564/there-needs-to-be-some-way-to-mute-the-entire-cron-detector) Since muting now operates at the environment level, disallow muting a monitor when it has no environments (as it would do nothing). Shows a helpful tooltip explaining that muting is only available when there are monitor environments.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| muteDisableProps.title = t( | ||
| 'Muting is only available when there are monitor environments' | ||
| ); | ||
| } |
There was a problem hiding this comment.
Bug: UI Masks True Reason for Disabled Button
When a monitor has no environments, the muteDisableProps.title is unconditionally overwritten, which loses the permission tooltip if the user lacks edit access. When both conditions are true (no permission and no environments), users see the environment message instead of the permission message, masking the actual reason the button is disabled.
There was a problem hiding this comment.
agree - the user can fix the env, then the permissions error will show up. might be nice if you could see both, but doesn't seem vital.
There was a problem hiding this comment.
Well it would be, the user creates an env, then they see they can't mute the monitor.
either way doesn't matter, this will go away in the future
evanpurkhiser
changed the title
| muteDisableProps.title = t( | ||
| 'Muting is only available when there are monitor environments' | ||
| ); | ||
| } |
There was a problem hiding this comment.
agree - the user can fix the env, then the permissions error will show up. might be nice if you could see both, but doesn't seem vital.
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-disable-mute-button-when-monitor-has-no-environments
branch
NEW-564: There needs to be some way to mute the entire cron detector
Since muting now operates at the environment level, disallow muting a monitor when it has no environments (as it would do nothing). Shows a helpful tooltip explaining that muting is only available when there are monitor environments.
Important
Not to be merged until the backend components are all released