Skip to content

Conversation

@mujacica
Copy link
Contributor

This commit adds backend support for Perforce version control integration:

  • Repository and code mapping functionality
  • Stacktrace linking for Perforce depot paths
  • Tests for integration, code mapping

Requires: #103287, #103171

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 19, 2025
@mujacica mujacica marked this pull request as ready for review November 19, 2025 12:59
@mujacica mujacica requested review from a team as code owners November 19, 2025 12:59
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 32.80000% with 84 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/perforce/repository.py 10.14% 62 Missing ⚠️
src/sentry/integrations/perforce/client.py 58.49% 22 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/perforce-backend   #103635      +/-   ##
==========================================================
- Coverage                  80.56%    80.55%   -0.02%     
==========================================================
  Files                       9265      9265              
  Lines                     395771    395883     +112     
  Branches                   25207     25207              
==========================================================
+ Hits                      318836    318885      +49     
- Misses                     76505     76568      +63     
  Partials                     430       430              

Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but am going to request review from the teams that own code mapping and release code since compare_commits is used for that

@cathteng cathteng requested review from a team November 19, 2025 19:36
srest2021
srest2021 previously approved these changes Nov 19, 2025
@srest2021 srest2021 dismissed their stale review November 19, 2025 21:52

Oops sorry meant only to comment 😭

@armenzg armenzg self-requested a review November 20, 2025 16:51
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mujacica All typing issues can be followed up on a new PR. This one does not need to block on it, however, I do want to push our typing levels higher.

I will review the tests tomorrow morning.

This commit adds backend support for Perforce version control integration:

- New Perforce integration with P4 client support
- Repository and code mapping functionality
- Stacktrace linking for Perforce depot paths
- Tests for integration, code mapping, and stacktrace linking
- Updated dependencies in pyproject.toml

The integration supports:
- Authentication via P4PORT, P4USER, P4PASSWD
- Code mapping between depot paths and project structure
- Source URL generation for stacktrace frames
- Integration with Sentry's repository and code mapping systems
@mujacica mujacica merged commit 65904df into master Dec 4, 2025
69 checks passed
@mujacica mujacica deleted the feat/perforce-backend-repo branch December 4, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants