feat(segment-enrichment): Introduce segment name normalization #103739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mjq
added a commit
that referenced
this pull request
Nov 24, 2025
Continues the work started in #103739. As a first step to adding incremental segment name clustering to segment enrichment, record each seen segment name (like we do for transaction names in Sentry's `event_manager`). To work around the different signatures for transactions and segment spans, I extracted as much of the logic as I could into a second function, with one caller per scenario. As with the previous PR, the changes are behind an org flag (organizations:normalize_segment_names_in_span_enrichment) for testing and easy rollback.
mjq
added a commit
that referenced
this pull request
Nov 26, 2025
Continues the work started in #103739. As a first step to adding incremental segment name clustering to segment enrichment, record each seen segment name (like we do for transaction names in Sentry's `event_manager`). To work around the different signatures for transactions and segment spans, I extracted as much of the logic as I could into a second function, with one caller per scenario. As with the previous PR, the changes are behind an org flag (organizations:normalize_segment_names_in_span_enrichment) for testing and easy rollback. Closes ENG-5951.
mjq
added a commit
that referenced
this pull request
Dec 2, 2025
Continues the work from #103739 and #103913. This PR ports the application of transaction name clusterer rules from Relay into segment enrichment. Relay will continue to apply transaction name clustering to spans from transactions, while this code will handle standalone spans (spans v2) and OTLP spans. See [the preamble to `sentry.ingest.transaction_clusterer.tree`](https://github.com/getsentry/sentry/blob/faca90e0cc06cf2492da22a01539352568dea565/src/sentry/ingest/transaction_clusterer/tree.py#L1-L46) for an explanation of how transaction name clustering rules are matched. Closes ENG-5747.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, transaction name clustering and normalization happens partly in Relay and partly in Sentry's
event_manager.save_transaction_events. This normalization only applies to transactions, and spans that are extracted from those transactions.For standalone spans and OTLP spans, we need to apply the clustering elsewhere. We will introduce it into the segment enrichment step of the span ingestion pipeline.
This PR introduces the first step of the process, stripping identifier-like patterns out of names that aren't explicitly parameterized (via the
sentry.span.sourceattribute). Future PRs will add interactions with the transaction clusterer (saving seen names and applying compiled clustering rules).The changes are behind an org flag (
organizations:normalize_segment_names_in_span_enrichment) for testing and easy rollback.Closes ENG-5953.